Bundle three.js examples in module build #238
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandonocasey @gkatsev Could we get some eyes on this PR? It fixes this library for users using a package manager (e.g. npm, Yarn, pnpm) as the library is currently broken for package manager users. Issue #188 explains the issue that is happening and the PR description of this PR should explain how this PR fixes it. |
brandonocasey
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #188
Specific Changes proposed
Issue #188 describes an issue where using the module build (
videojs-vr.es.js) will break with the errorTHREE is not defined. This is because the three.js example files are not bundled and so module consumers receive the unchanged version when installing three.js from npm.This PR adds a custom resolver which will resolve the three.js example files and mark them as non-external. This matches the output from the commonjs bundle where the examples are part of the output bundle and thus the changes from rollup replace are preserved.
Requirements Checklist